Replace sonarcloud with codecov and lint ci badge #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows + update actions Reuse build workflow in publish workflow see [reusable workflow](https://docs.github.com/en/actions/using-workflows/reusing-workflows) Use codecov.yml config from https://docs.codecov.com/docs/quick-start#tips-and-tricks
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
22 tasks
BSchilperoort
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Codecov seems to work, nice 👍
The one thing I dislike from an aesthetic view is how github names the actions:
Perhaps you can style them like this:
Build distribution 📦 / build
Static code analysis 🔍️ / lint
Testing and type checking 🐛 / test
It would then be a bit more clear which workflow does what. Of course the emojis are optional haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #441
Also renames the ci workflows to match their content.