Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with pydantic #334

Closed
wants to merge 21 commits into from
Closed

Config with pydantic #334

wants to merge 21 commits into from

Commits on Feb 21, 2023

  1. Use pydantic for config validation 

    Refs #332
    @sverhoeven
    sverhoeven committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    f72339e View commit details
    Browse the repository at this point in the history

  2. Drop unused validator

    @sverhoeven
    sverhoeven committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    7337be3 View commit details
    Browse the repository at this point in the history

  3. Fix available_parameter_sets()

    @sverhoeven
    sverhoeven committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    81ad761 View commit details
    Browse the repository at this point in the history

  4. Drop tests for non-existing code

    @sverhoeven
    sverhoeven committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    eb58985 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Move tests for parametersetdb to own sub dir

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    f09f794 View commit details
    Browse the repository at this point in the history

  2. Move test fixtures for parametersetdb to own file

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    6157666 View commit details
    Browse the repository at this point in the history

  3. Implement overwrite

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ad838bd View commit details
    Browse the repository at this point in the history

  4. Add tests for Config

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9ab9107 View commit details
    Browse the repository at this point in the history

  5. Numba 0.56.4 does not support Python 3.11

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d957464 View commit details
    Browse the repository at this point in the history

  6. Bump versions of pre-commit 

    Was getting
```
RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

```
    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ce3bf18 View commit details
    Browse the repository at this point in the history

  7. Use CFG.bla instead of CFG['bla'] 

    Also
* made . the default value for directories
* renamed Config class to Configuration, as mypy was confused by nested Config.Config class
* added filename to validation error
* create dir before assigning to CFG field
* docstrings for Configuration fields
* dropped test in tests/parameter_sets/__init__.py, as it rewrote my config file
    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    8d5d7b4 View commit details
    Browse the repository at this point in the history

  8. Prepend parameterset_dir to parameter set paths

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0c0081b View commit details
    Browse the repository at this point in the history

  9. Make ParameterSet and ExampleParameterSet pydantic models

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1d61441 View commit details
    Browse the repository at this point in the history

  10. Fix tests

    @sverhoeven
    sverhoeven committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    df3466c View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Fix tests even more

    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2fad561 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/apptainer' into config-with-pyda… 

    …ntic
    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5382cd4 View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    bcb5d74 View commit details
    Browse the repository at this point in the history

  4. Test docs

    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    08bb34c View commit details
    Browse the repository at this point in the history

  5. Mention pydantic in changelog

    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    9a7be33 View commit details
    Browse the repository at this point in the history

  6. Remember py3.11 is not supported due to mamba

    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    61bdbaf View commit details
    Browse the repository at this point in the history

  7. Add expand user for paths + forbid extra attribs 

    To sync config code with docs
    @sverhoeven
    sverhoeven committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    6abc991 View commit details
    Browse the repository at this point in the history