Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apptainer support #324

Closed
wants to merge 8 commits into from
Closed

Apptainer support #324

wants to merge 8 commits into from

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Nov 29, 2022

Fixes #290

This PR does not mark singularity_dir as deprecated, this is done in #334

Was getting
```
RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

```
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

69.3% 69.3% Coverage
1.4% 1.4% Duplication

@sverhoeven sverhoeven marked this pull request as ready for review March 6, 2023 13:38
sverhoeven added a commit to eWaterCycle/infra that referenced this pull request Mar 6, 2023
Except where used in combination with python ewatercycle package
As eWaterCycle/ewatercycle#324 has not been merged/released yet
@sverhoeven sverhoeven mentioned this pull request Mar 7, 2023
5 tasks
Copy link
Collaborator

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR mostly renames stuff. Would be good to test it together with other recent changes in #334

@Peter9192
Copy link
Collaborator

Singularity still used a lot in examples and docs. Would be nice to update at some point

@Peter9192 Peter9192 mentioned this pull request Mar 10, 2023
@Peter9192
Copy link
Collaborator

Note that I've made #340, which solves merge conflicts between this branch and #339

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sverhoeven
Copy link
Member Author

Singularity still used a lot in examples and docs. Would be nice to update at some point

Docs has singularity to clearify apptainer fork.
The example notebooks now use apptainer, but they have not been run with that setup.

@Peter9192
Copy link
Collaborator

Merged as part of #340

@Peter9192 Peter9192 closed this Mar 22, 2023
@BSchilperoort BSchilperoort deleted the apptainer branch August 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apptainer support
2 participants