Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is call… #264

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is call… #264

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af69821
Dont call finalize() on Lisflood.bmi when Lisflood.finalize() is call…
sverhoeven Sep 29, 2021
68540e0
Use finalize in example
sverhoeven Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ewatercycle/models/lisflood.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,11 @@ def parameters(self) -> Iterable[Tuple[str, Any]]:
("end_time", self._end.strftime("%Y-%m-%dT%H:%M:%SZ")),
]

def finalize(self) -> None:
"""Perform tear-down tasks for the model."""
# Finalize function of bmi class of lisflood is kaput, so not calling it
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a warning here? Or open new issue to remind us to fix it properly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created eWaterCycle/lisflood-code#1

del self.bmi


# TODO it needs fix regarding forcing
# def reindex_forcings(
Expand Down