Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better non-rectilinear grid support #389

Open
sverhoeven opened this issue Oct 30, 2023 · 0 comments
Open

Better non-rectilinear grid support #389

sverhoeven opened this issue Oct 30, 2023 · 0 comments
Labels
models Issues related to (base) models. For model specific issues open an issue on their repository

Comments

@sverhoeven
Copy link
Member

In https://github.com/eWaterCycle/pywflow/blob/cf44beb2e4dceb5e1bd794e50145a1bf1b8c6f55/src/ewatercycle_wflowjl/model.py#L34 and https://github.com/eWaterCycle/pywflow/blob/cf44beb2e4dceb5e1bd794e50145a1bf1b8c6f55/src/ewatercycle_wflowjl/model.py#L238 better support was added for non-rectilinear grids. However this is only usefull in the wflowjl plugin. It would be nice to move those functions to https://github.com/eWaterCycle/ewatercycle/blob/main/src/ewatercycle/base/model.py .

We will need to add unit tests as wflowjl plugin only has notebooks.
@sverhoeven sverhoeven mentioned this issue Oct 30, 2023
Merged
2 tasks
@BSchilperoort BSchilperoort added the models Issues related to (base) models. For model specific issues open an issue on their repository label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
models Issues related to (base) models. For model specific issues open an issue on their repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sverhoeven @BSchilperoort