-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to ewc-plugin structure. Add forcing generation #7
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@sverhoeven Wflow.jl now uses the grid types "scalar", "points" and "unstructured". I guess changes will have to be made in ewatercycle to support those in e.g. |
You overwrote those methods in src/ewatercycle_wflowjl/model.py:WflowJl class, but indeed moving those to ewatercycle would be nicer for the next non-rectilinear plugin. Created eWaterCycle/ewatercycle#389 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
I was able to install (editable mode) and run the notebooks.
I used parameter set from dcache.
The model was running quit slow so I did not run full period.
@BSchilperoort @sverhoeven can this be merged? |
This PR overhauls this repository.
Added:
Note for reviewers: Just look at the new repo structure and files https://github.com/eWaterCycle/pywflow/tree/ewatercycle_plugin Basically everything is new.
Too many files have been removed to make the "files changed" tab useful.
To do after this pr: