Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks to eWaterCycle 2.0, fix forcing missing params #4

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

BSchilperoort
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BSchilperoort BSchilperoort changed the title Update notebooks to eWaterCycle 2.0 Update notebooks to eWaterCycle 2.0, fix forcing missing params Nov 29, 2023
@BSchilperoort BSchilperoort linked an issue Nov 29, 2023 that may be closed by this pull request
@BSchilperoort BSchilperoort marked this pull request as ready for review November 29, 2023 12:27
Copy link

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing marrmot! I test those two notebooks locally and they all run without problem. Let's get it merged! (also make a new release then?)

@BSchilperoort BSchilperoort merged commit a1f338d into main Dec 8, 2023
1 check passed
@BSchilperoort BSchilperoort deleted the bugfixes branch December 8, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants