Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dashed varname option #148

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Implement dashed varname option #148

merged 2 commits into from
Apr 17, 2023

Conversation

BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Apr 5, 2023

Based on #53, I've added the option to have the output variable name underscores replaced with dashes (--dashed-varname).

For example
era5_temperature-of-snow-layer_1999_hourly.nc instead of
era5_temperature_of_snow_layer_1999_hourly.nc.

I am not sure if we should add this (now), because there are more and more optional arguments, but it is quite useful, as @bouweandela outlined in the issue.

I would not be against making this the default in the future.

@BSchilperoort BSchilperoort linked an issue Apr 5, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #148 (5ef186e) into main (e6c85c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          14       14           
  Lines         592      596    +4     
=======================================
+ Hits          590      594    +4     
  Misses          2        2           

Copy link
Collaborator

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just discussed this and I agree on the general outline. Let's update #53 with a summary of the main pro's and cons of making this the default, so we can have a focused discussion on the long-term behaviour.

@BSchilperoort
Copy link
Member Author

Note that I have decided to change the argument to --dashed-varname instead of --dashed_varname, after doing some more research on what is more commonly used/better.

@BSchilperoort BSchilperoort merged commit 6c85d09 into main Apr 17, 2023
@BSchilperoort BSchilperoort deleted the dashed_varnames branch April 17, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants