Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21560] Regenerate types Fast-DDS-Gen v3.3.1 #198

Merged
merged 1 commit into from
Nov 29, 2024
Merged

[21560] Regenerate types Fast-DDS-Gen v3.3.1 #198

merged 1 commit into from
Nov 29, 2024

Conversation

EugenioCollado
Copy link

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado added this to the v1.4.3 milestone Nov 27, 2024
@MiguelCompany MiguelCompany self-requested a review November 27, 2024 13:25
@github-actions github-actions bot added the ci-pending PR which CI is running label Nov 27, 2024
MiguelCompany
MiguelCompany approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EugenioCollado EugenioCollado mentioned this pull request Nov 28, 2024
Merged
6 tasks
@EugenioCollado EugenioCollado changed the title Regenerate types Fast-DDS-Gen v3.3.1 [21560] Regenerate types Fast-DDS-Gen v3.3.1 Nov 28, 2024
@EugenioCollado EugenioCollado mentioned this pull request Nov 28, 2024
Merged
6 tasks
@rsanchez15
Copy link
Contributor

rsanchez15 commented Nov 29, 2024 •
edited
Loading

The Windows CI for version 1.4.x started to fail 4 days ago. The fail does not come from any change on Fast DDS Python as there wasn't any commit in this repo since one month ago. Let's merge this and look at this issue in a follow-up PR.

Issue ticket: 22354

@rsanchez15 rsanchez15 merged commit 9fba68d into 1.4.x Nov 29, 2024
6 of 8 checks passed
@rsanchez15 rsanchez15 deleted the feature/regenerate_types_gen_v3.3.1 branch November 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@EugenioCollado @rsanchez15 @MiguelCompany