Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21486] Fix HelloWorld example with TopicDataType refactored code #183

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Aug 21, 2024

Description

When updating the Fast DDS python code to the new TopicDataType methods, the HelloWorld example update was missed. This PR updates changes those calls to use the new API.

Fixes #182

Contributor Checklist

  • Commit messages follow the project guidelines.
  • ❌: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
    • We will update the CI so it runs the example in a follow-up
  • ❌: Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v2.0.0 milestone Aug 21, 2024
@JesusPoderoso JesusPoderoso self-assigned this Aug 21, 2024
@MiguelCompany MiguelCompany self-requested a review August 21, 2024 06:22
@github-actions github-actions bot added the ci-pending PR which CI is running label Aug 21, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Aug 21, 2024
@JesusPoderoso JesusPoderoso merged commit 6ca558c into main Aug 21, 2024
6 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/example branch August 21, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'HelloWorldPubSubType' object has no attribute 'setName'. Did you mean: 'set_name'?
2 participants