Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21321] Split Time_t.i in dds::Time_t and rtps::Time_t #164

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[21321] Split Time_t.i in dds::Time_t and rtps::Time_t #164

merged 1 commit into from
Jul 23, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 15, 2024 •
edited by JesusPoderoso
Loading

Description

Contributor Checklist

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.0.0 milestone Jul 15, 2024
@Mario-DL Mario-DL mentioned this pull request Jul 15, 2024
Merged
12 tasks
@Mario-DL Mario-DL requested a review from EduPonz July 15, 2024 12:58
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 15, 2024
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for EduPonz July 22, 2024 13:37
JesusPoderoso
JesusPoderoso approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 22, 2024
@Mario-DL Mario-DL requested a review from JesusPoderoso July 23, 2024 08:07
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 23, 2024
@Mario-DL Mario-DL requested review from JesusPoderoso and removed request for JesusPoderoso July 23, 2024 08:38
@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for MiguelCompany and JesusPoderoso July 23, 2024 08:48
@JesusPoderoso JesusPoderoso removed the ci-pending PR which CI is running label Jul 23, 2024
@MiguelCompany MiguelCompany merged commit ae2dfc6 into main Jul 23, 2024
7 of 10 checks passed
@MiguelCompany MiguelCompany deleted the feature/21321 branch July 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @JesusPoderoso @MiguelCompany