Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5052: Guard potentially undefined e_PAGE constant #5053

Closed
wants to merge 1 commit into from

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Aug 2, 2023

Motivation and Context

Fixes: #5052

Description

Guard potentially undefined e_PAGE constant

How Has This Been Tested?

By manually running through the "How to Reproduce" steps in #5052

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@Deltik Deltik requested a review from Moc August 2, 2023 11:54
@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit 68b2401 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 1

The test coverage on the diff in this pull request is 0.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.1% (-0.8% change).

View more on Code Climate.

@CaMer0n
Copy link
Member

CaMer0n commented Aug 16, 2023

Thank you. Closed in favor of 5ff319c

@CaMer0n CaMer0n closed this Aug 16, 2023
@Deltik Deltik deleted the fix/5052 branch August 16, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Force user to update settings" breaks home page for logged in users on PHP 8
3 participants