Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not define the PAGE_NAME on profile page #5264

Open
fizi opened this issue May 26, 2024 · 6 comments
Open

Not define the PAGE_NAME on profile page #5264

fizi opened this issue May 26, 2024 · 6 comments
Labels
type: bug A problem that should not be happening

Comments

@fizi
Copy link

fizi commented May 26, 2024

What e107 version are you using?

Latest Github version (just updated)

Bug description

Not define the PAGE_NAME on profile page.
Appear "commets" on pagename.

How to reproduce

Go to profile page.

Expected behavior

Need define the profile page title.

What browser(s) are you seeing the problem on?

Firefox

PHP Version

PHP 8.1.10 (localhost)

@fizi fizi added the type: bug A problem that should not be happening label May 26, 2024
@tgtje
Copy link
Contributor

tgtje commented May 26, 2024

@fizi hope it is this? i can not replicate

profile page title in English lan_usersettings:
if(!defined('PAGE_NAME')) { define("PAGE_NAME", "User Settings"); }

When using Hungarian lan_usersettings : this is in language pack :

define("PAGE_NAME", "Felhasználói beállítások"); so it misses the IF...
that lang file is 6 years old, the change was made 4 years ago...

@fizi
Copy link
Author

fizi commented May 26, 2024

page-name-error
This in the lan_usersettings.php but the lan_user.php haven't it. (user.php)

@tgtje
Copy link
Contributor

tgtje commented May 26, 2024

Would like to help, but i do not know what you expect to see ? eg what does PAGE_NAME is UNDEFINED hold.

The image looks like the comment.php displaying a styled profile.
the above part is displayed WHEN comments are enabled ANd user/options/prefs Allow comments in user profile is ENABLED.
when DISabled profile should display > member profile..

wx

@Jimmi08
Copy link
Contributor

Jimmi08 commented May 26, 2024

I am afraid this is related to using 2x tablerender() - one for the user page and, the second for comments. Check your theme and templates for using PAGE_NAME. The same for breadcrumbs.

@tgtje
Copy link
Contributor

tgtje commented May 26, 2024

Adding : this behaviour happens on profile page (user.php)

@fizi
Copy link
Author

fizi commented May 26, 2024

Yes, this happens on profile page. If the comment disabled - the page name appears normally, if the comment enabled - appears "0 comment"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants