Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong setting of mainRenders in e_Render class #5268

Open
Jimmi08 opened this issue May 28, 2024 · 2 comments
Open

[Bug]: Wrong setting of mainRenders in e_Render class #5268

Jimmi08 opened this issue May 28, 2024 · 2 comments
Labels
type: bug A problem that should not be happening

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented May 28, 2024

What e107 version are you using?

Latest Github version (just updated)

Bug description

		private function getMainRender()
		{

			if(isset($this->mainRenders[0]))
			{
				return $this->mainRenders[0];
			}

			return array();

		}

Value on user profile with comments ON:

[mainRenders:e_render:private] => Array
        (
            [0] => Array
                (
                    [list] => 1
                    [uniqueId] => 
                    [menuArea] => 0
                    [menuCount] => 0
                    [menuTotal] => 0
                    [setStyle] => main
                    [caption] => 0 Comments
                )

            [1] => Array
                (
                    [list] => 
                    [uniqueId] => 
                    [menuArea] => 0
                    [menuCount] => 0
                    [menuTotal] => 0
                    [setStyle] => main
                    [caption] => Member Profile
                )

        )

How to reproduce

  1. Set comments on user profile ON
  2. check with the bootstrap5 theme

image

Workaround - just partial fix

	  {SETSTYLE=raw}
	  {PROFILE_COMMENTS}

result

image

Expected behavior

Comment tablerender shouldn't influence the main render

What browser(s) are you seeing the problem on?

Chrome / Brave

PHP Version

8.1

@Jimmi08 Jimmi08 added the type: bug A problem that should not be happening label May 28, 2024
@tgtje
Copy link
Contributor

tgtje commented May 28, 2024

related #5264

@fizi
Copy link

fizi commented May 29, 2024

The problem with this is that if I set it this way, the caption does not appear. The caption cannot be overwritten with comments title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants