Converting pie charts into bar charts in visualization #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing done: By running Jupyter notebooks and comparing them with previous pie charts
|
Testing:
|
|
@shankari Please review |
|
Can you explain what you mean by this? How did you compare the charts? |
shankari
requested changes
Apr 20, 2023
Comment on lines
+128
to
+129
| " data = pd.DataFrame({\"Mode_confirm\": labels_mc,\n", | ||
| " \"Number of Trips\": values_mc})\n", |
There was a problem hiding this comment.
I don't see why you have this copy-pasted before every line.
Can you please explain:
- why we need to create a separate data frame for the visualization of bar charts when we did not for pie charts?
- why this needs to be copy-pasted instead being refactored into common code with the same interface?
Comment on lines
-252
to
-261
| "\n", | ||
| " #data\n", | ||
| " miles_dict = dict(zip(miles['Mode_confirm'], miles['Total (miles)']))\n", | ||
| "\n", | ||
| " labels_m = []\n", | ||
| " values_m = []\n", | ||
| "\n", | ||
| " for x, y in miles_dict.items():\n", | ||
| " labels_m.append(x)\n", | ||
| " values_m.append(y)\n", |
There was a problem hiding this comment.
why is this no longer required?
The general rule of thumb for replacing pie charts is stacked bar graphs, not bar graphs directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done: By running Jupyter notebooks and comparing them with previous pie charts