Add tentative support for the "air" mode #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not merging this to main yet because air then dwarfs everything else in terms of emissions. We already show this as "other" on the pie chart, but we ignore other trips for emission calulations, making them look lower than they actually are. This change reintroduces them, but then all other emissions are dwarfed in the timeline. Need to think about how best to represent this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not merging this to main yet because air then dwarfs everything else in terms
of emissions. We already show this as "other" on the pie chart, but we ignore
other trips for emission calulations, making them look lower than they actually
are.
This change reintroduces them, but then all other emissions are dwarfed in the
timeline.
Need to think about how best to represent this.
@zackAemmer can you think about this when you work on e-mission/e-mission-docs#757?