Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify calls to read json resource from e-mission-common in generate_plots.py #164

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Commits on Oct 2, 2024

  1. Update the STUDY_CONFIG in docker-compose.dev.yml config file with th…

    …e program/study name from the database name of the dataset.
    iantei committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2d81075 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    242a7ea View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Load read_json_resource() from e-mission-common

    - Pass labels instead of dynamic_labels to the notebooks
    - labels can either be:
          - Custom labels from the program deployment config, from nrel-openpath-deploy-configs
          - In case, we do not have custom labels for the program/study, load default labels from e-mission-common with read_json_resource
    iantei committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    4c05924 View commit details
    Browse the repository at this point in the history
  2. Remove call to read_json_resource("label-options.default.json") from …

    …e-mission-common in scaffolding.py
    
    Replace dynamic_labels with "labels"
        - labels could be either default labels or dynamic labels (provided for program/study) depending on availability in config file
        - Use labels passed from notebook instead of calling read_json_resource("label-options.default.json") from e-mission-common
    Remove async and await for mapping_color_labels() and translate_values_to_labels()
        Remove filtering for dynamic_labels availability, as we will only have either labels or dynamic_labels.
    Update load_viz_notebook_* functions to use labels instead of dynamic_labels
    iantei committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3b5b346 View commit details
    Browse the repository at this point in the history
  3. Replace dynamic_labels with labels. Remove await from mapping_color_l…

    …abels() and translate_values_to_labels().
    iantei committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    413420d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db67977 View commit details
    Browse the repository at this point in the history
  5. Replace dynamic_labels with labels in generic_timeseries notebook. Re…

    …move filter for dynamic_labels, since we pass either dynamic_labels or labels based on the availability of dynamic labels in program/study config.
    iantei committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ab70832 View commit details
    Browse the repository at this point in the history
  6. Replace dynamic_labels with labels in mode_specific_metrics notebook.…

    … Remove await for mapping_color_labels() and translate_values_to_labels().
    iantei committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a050320 View commit details
    Browse the repository at this point in the history
  7. Replace dynamic_labels with labels. Remove check for dynamic_labels s…

    …ince we pass dynamic labels or labels based on the availabilty in study/program's config file.
    iantei committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    595876d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    876bdc2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7815a10 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    2916df2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    551c0cd View commit details
    Browse the repository at this point in the history