Fix for redesigned CI/CD pipeline failure #144
Conversation
Fix for Pipeline failure: e-mission#125 (comment)
|
@MukuFlash03 waiting for the "two tag upload" before I review and merge |
|
Almost done, running some CI/CD tests to ensure it works. |
This will ensure that if the CI/CD pipeline fails in any prior steps such as the docker related ones, the .env file isn't updated. This is because the the docker failures can include errors image not found which can occur due to incorrect tags.
|
Added the changes. Details on successful testing in this comment in the original PR. |
There was a problem hiding this comment.
I am not going to insist on this right now, but as part of e-mission/e-mission-docs#1082, we should consider putting the notebook tag in here as well, and just using this instead of the artifacts
| run: | | ||
| set -a; source .env.repoTags; set +a | ||
| echo "Restoring latest frontend image tag from .env.repoTags" | ||
| echo "FRONTEND_IMAGE_TAG=${FRONTEND_IMAGE_TAG}" >> $GITHUB_ENV |
There was a problem hiding this comment.
I am not going to insist on this, but we should revisit this as part of
e-mission/e-mission-docs#1082
" Consider switching from $GITHUB_ENV to step outputs. I think that the step outputs are the recommended approach to pass values from one step to another, but we should verify"
Failed workflow run
Changes:
Adding suffix to image tag to match image name in docker-compose.yml
Details in these comments (link, link)