🐛 Change the way in which we read the configuration variables #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes made to support the new configuration methodology failed with this error
```
ERROR:root:name 'os' is not defined
Traceback (most recent call last):
File "/usr/src/app/emission/net/ext_service/push/notify_interface.py", line 27, in <module>
logging.warning(f"Push configured for app {push_config.get('PUSH_APP_PACKAGE_NAME')} using platform {os.getenv('PUSH_PROVIDER')} with token {os.getenv('PUSH_SERVER_AUTH_TOKEN')[:10]}... of length {len(os.getenv('PUSH_SERVER_AUTH_TOKEN'))}")
NameError: name 'os' is not defined
```
The fix is simply to use `push_config.get` instead of `os.getenv`. Also logged
the full exception instead of simply generating a warning that the functionality is not supported.
Testing done:
- Before: error above
- After:
```
Found configuration, overriding...
Activating the environment...
Run trip labeling reminder...
WARNING:root:About to read push configuration...
WARNING:root:Push configured for app gov.nrel.cims.openpath using platform firebase with token ... of length 152
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made to support the new configuration methodology failed with this error
The fix is simply to use
push_config.getinstead ofos.getenv. Also logged the full exception instead of simply generating a warning that the functionality is not supported.Testing done: