Skip to content

Commit

Permalink
refactor: simplify icons code and make them reusable
Browse files Browse the repository at this point in the history
Merge in SUN/veera-components from refactor-EBS-459-storybook-structure to master

Squashed commit of the following:

commit e973ef75cb5aff152a0e31993e6165c74642b009
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:35:47 2023 +0200

    format(storybook): minor formatting

commit 2ad02af4a5cf80b13b8f88e7766cd2f801f58ae6
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:33:42 2023 +0200

    refactor(icons): removed hardcoded color from user icon (to be added in an app itself)

commit e8fd48a7c4bdc43b61c5f2b73a7c5ab060c00d81
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:30:36 2023 +0200

    refactor(icons): removed hardcoded color from sort icon (to be added in an app itself)

commit 5708ff702196b79c2f9a4334693be698b9bfaa47
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:28:03 2023 +0200

    refactor(icons): removed hardcoded color from happy-face and sad-face icons (to be added in an app itself)

commit 2fab7fa6c12e953a932fae1b7fcd48bf6656c499
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:26:09 2023 +0200

    refactor(icons): removed an unnecessary fill attribute from info icon

commit 7c6fb5c9f39442eef160081b71e9dd699d5f3fc1
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:21:34 2023 +0200

    refactor(icons): simplified path in error-outline icon

commit 0d57fda39179c49aa46097c7f1324d8a05e37300
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:15:49 2023 +0200

    refactor(icons): removed an unused attribute from email icon

commit 1fb3ce3f6d52a3cb323d7dee24a701bdf0f1ffaf
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:11:36 2023 +0200

    refactor(icons): removed unnecessary group tags from all SVG icons

commit c98e53f9d71145884b52836016e3f6e4e58e1d77
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:06:30 2023 +0200

    feat(icons): mark as a linting error presence of a g tag inside SVG markup with only one child

    see simple-icons/svglint#56

commit 909737f29f983014167267986fdd1cc4a9cfd979
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:03:14 2023 +0200

    feat(icons): do not truncate errors list when linting icons

    see simple-icons/svglint#56

commit eaa4bbf72bfacf7ea6cddf03fc55d1f5ef977461
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:01:59 2023 +0200

    refactor(icons): simplified path in check-circle-outline icon

commit b100f0e59272b738d915e52276a4c6b45b0fa848
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 20:01:14 2023 +0200

    refactor(icons): removed hardcoded color and opacity from arrow-up-alt icon (to be added in an app itself)

commit b3093c5d80c88d16ca75a5ee2ff450efea5cadef
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 19:56:20 2023 +0200

    feat(icons): added more rules to SVGLint config

commit 75364d48869d08799d1f52eb9c87719838887aea
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 19:55:38 2023 +0200

    refactor(icons): removed hardcoded color from edit icon (to be added in an app itself)

commit 8e3556503caf41ff135f610f73efd3bf47d0df01
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 19:55:11 2023 +0200

    refactor(icons): removed hardcoded color and opacity from arrow-down-alt icon (to be added in an app itself)

commit 841649248b51c3bcdc3943b85d147ddeea78090d
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 19:10:07 2023 +0200

    refactor(icons): removed hardcoded color from arrow-up icon (to be added in an app itself)

commit 446e6bf9503512c044438fbe2187de20599a1a69
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 18:52:27 2023 +0200

    refactor(icons): removed hardcoded color from arrow-down icon (to be added in an app itself)

commit f69e285a06847c6faec28ad7d5a5dfd73161e451
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 18:51:53 2023 +0200

    refactor(icons): removed hardcoded color from action icon (to be added in an app itself)

commit f2c3e8b87bb558d13a45a086923d13029b36e6c6
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 18:43:52 2023 +0200

    feat(icons): added an SVG linter and lint:svg command

commit 3229f0ad8d6ddf9456684f11eba83337615ff808
Author: Aleksandr Beliaev <[email protected]>
Date:   Sun Jan 15 18:12:54 2023 +0200

    feat(storybook): expand height of All icons story when viewed in Docs tab

... and 5 more commits
  • Loading branch information
Aleksandr Beliaev authored and Aleksandr Beliaev committed Jan 16, 2023
1 parent 19f6674 commit 7011763
Show file tree
Hide file tree
Showing 50 changed files with 660 additions and 89 deletions.
45 changes: 45 additions & 0 deletions .svglintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
module.exports = {
rules: {
elm: {
svg: 1,
'svg > style': 0,
'g > :only-child': 0,
},
attr: [
{
'rule::selector': 'svg',
viewBox: true,
version: false,
id: false,
'data-name': false,
class: false,
style: false,
xmlns: 'http://www.w3.org/2000/svg',
fill: false,
'xmlns:dc': false,
'xmlns:cc': false,
'xmlns:rdf': false,
'xmlns:svg': false,
'xml:space': false,
'xmlns:sodipodi': false,
'xmlns:inkscape': false,
x: false,
y: false,
},
{
'rule::selector': 'svg g',
style: false,
fill: false,
id: false,
class: false,
},
{
'rule::selector': 'svg path',
style: false,
fill: false,
'fill-opacity': false,
class: false,
},
],
},
};
Binary file removed libs/icons/src/lib/png/business.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/consumer.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/country.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/culture.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/disability.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/documents.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/education.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/error.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/family.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/grants.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/healthcare.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/home.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/justice.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/language.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/menu-icon.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/money.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/my-data.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/security.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/special-req.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/success.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/traffic.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/warning.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/work.png
Binary file not shown.
Binary file removed libs/icons/src/lib/png/x-icon.png
Binary file not shown.
4 changes: 2 additions & 2 deletions libs/icons/src/lib/svg/action.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 2 additions & 5 deletions libs/icons/src/lib/svg/arrow-down-alt.svg
4 changes: 2 additions & 2 deletions libs/icons/src/lib/svg/arrow-down.svg
7 changes: 2 additions & 5 deletions libs/icons/src/lib/svg/arrow-up-alt.svg
9 changes: 2 additions & 7 deletions libs/icons/src/lib/svg/arrow-up.svg
4 changes: 1 addition & 3 deletions libs/icons/src/lib/svg/call.svg
6 changes: 3 additions & 3 deletions libs/icons/src/lib/svg/check-circle-outline.svg
17 changes: 7 additions & 10 deletions libs/icons/src/lib/svg/edit.svg
4 changes: 1 addition & 3 deletions libs/icons/src/lib/svg/email.svg
8 changes: 5 additions & 3 deletions libs/icons/src/lib/svg/error-outline.svg
6 changes: 3 additions & 3 deletions libs/icons/src/lib/svg/happy-face.svg
2 changes: 1 addition & 1 deletion libs/icons/src/lib/svg/info.svg
4 changes: 1 addition & 3 deletions libs/icons/src/lib/svg/location.svg
6 changes: 3 additions & 3 deletions libs/icons/src/lib/svg/sad-face.svg
4 changes: 1 addition & 3 deletions libs/icons/src/lib/svg/screen-share.svg
6 changes: 3 additions & 3 deletions libs/icons/src/lib/svg/sort.svg
4 changes: 2 additions & 2 deletions libs/icons/src/lib/svg/user.svg
1 change: 0 additions & 1 deletion libs/icons/src/lib/svg/veera.svg
Diff not rendered.
Loading

0 comments on commit 7011763

Please sign in to comment.