-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollapp): Updating x/rollapp to accommodate generalized DA layer interface #974
Open
spoo-bar
wants to merge
35
commits into
dymensionxyz:main
Choose a base branch
from
spoo-bar:spoorthi/generalized-rollapp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(rollapp): Updating x/rollapp to accommodate generalized DA layer interface #974
spoo-bar
wants to merge
35
commits into
dymensionxyz:main
from
spoo-bar:spoorthi/generalized-rollapp
+2,463
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the deprecated functions and modules from the codebase. The following changes were made: - Removed the RandomizedParams function from the sequencer and eibc modules - Removed the Route, QuerierRoute, and LegacyQuerierHandler functions from the eibc, delayedack, rollapp, sequencer, and streamer modules These changes were made to clean up the codebase and remove unnecessary and deprecated code.
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to generalize and standardize the DA Layers that a rollapp can decide to use. The sequencers can then multiplex between different DAs. Using this, the inclusions of blob can be proved and allows for a trustless dispute process to prove inclusion, non-inclusion or tampering.
The main change includes the change of
DAPath
from string to a concrete type inMsgUpdateState
. Rest of the fields stay the same.Every new da layer supported will need to implement the following interface to satisfy the requirements.
Description
v2.MsgUpdateState
which differs from the existing msg in theDAPath
field.v1.MsgUpdateState
can be deprecated when all da layers are supported by the v2 type.DAPath
field which also holds information about the type of da layer being used. e.g values arecelestia
,avail
etcDAPath
in theStateInfo
is still a string field. Thev2.MsgUpdateState
will marshall the newDAPath
and store it as string and unmarshall when it needs to be read.DALayer
interface which needs to be implemented by every da layer which will be supported.References:
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: