Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option initial_send on Discovery #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fluffysquirrels
Copy link

When using struct mdns::discover::Discovery, the current implementation waits for mdns_query_interval before sending the first query.

With this patch, Discovery can be configured with Discovery::initial_send(..) to send out a query immediately when the response stream starts.

I left initial_send as false by default to preserve the existing behaviour, but I think true may be a better default.

@fluffysquirrels
Copy link
Author

I've just seen PR #34, which unconditionally does the same as this PR, as in the initial request is always sent immediately.

I'm happy for either to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant