This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
catimg support #1570
Merged
catimg support #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes broken size parameter from the last implementation
|
(thanks, @dylanaraps !) |
|
I am not able to make it work by my side. But CatImg works
https://ptero.co/iduwiwohoc.diff Any idea why? |
matt-fidd
pushed a commit
to matt-fidd/neofetch
that referenced
this pull request
Sep 12, 2022
Fixes broken size parameter from the last implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1569
This is a PR to re-implement
catimgsupport. It also fixes a bug with the previous implementation where one of the optional size parameters could make the image overflow into the text.shellcheckpasses and all (modified) lines are below 100 characters.