On demand service api #33
Open
+82
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fyzu
requested changes
Jun 29, 2023
| @@ -394,7 +405,10 @@ export class Subscriptions { | |||
| event[eventPropertyName] = values[eventPropertyIndex] | |||
| }) | |||
|
|
|||
| subscription[event.eventSymbol]?.listeners.forEach((listener) => listener(event)) | |||
| @@ -309,6 +318,8 @@ export class Subscriptions { | |||
| Object.entries(stateChange).forEach(([key, val]) => { | |||
| this.state[key] = val | |||
| }) | |||
|
|
|||
| this.stateSubscriptions.forEach((listener) => listener(this.state)) | |||
There was a problem hiding this comment.
To know if it is replying now or not, how much time has replayed.
| @@ -78,3 +78,10 @@ export interface ISubscribeMessage { | |||
| addTimeSeries?: ITimeSeriesList | |||
| removeTimeSeries?: ISubscriptionList | |||
| } | |||
|
|
|||
| type OnDemandMethod = 'replay' | 'setSpeed' | 'stopAndResume' | 'stopAndClear' | |||
There was a problem hiding this comment.
Create a separate class for onDemand and add typed methods:
- reply
- setSpeed
- stopAndResume
- stopAndClear
| } else if (method === 'clear') { | ||
| this.endpoint.invokeOnDemandService( | ||
| { op: 'stopAndClear', args: [] }, | ||
| changeStateIfSuccess({ speed: 0, replay: false, clear: true, time: 0 }) |
There was a problem hiding this comment.
How's it connected with the onDemand service?
There was a problem hiding this comment.
You mean state? I think it implies to change the state when we invoke any of onDemand methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.