Revive Hits - Better (Much Faster!) than Ever #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 8 +7
Lines 19 105 +86
=====================================
+ Hits 19 105 +86
Continue to review full report at Codecov.
|
nelsonic
changed the title
|
@iteles no "rush" to Merge this, but would be good at |
|
@nelsonic I just didn't know whether it was ready for merging 😊 |
|
Added basic UI for creating Badges on the Homepage: http://hits.dwyl.io |
|
Final "MVP" UI: @iteles PR assigned. thanks for reviewing/merging. |
iteles
approved these changes
Sep 4, 2017
|
@iteles thank you! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@iteles this PR dusts off the "Hits" project so that we can use it as a "beginners" node.js tutorial.
Issues resolved:
Fix/Revive the "Hits" project fixes Hit Count not working repo-badges#27 and is hit count working? repo-badges#24
Deploy to "better" (faster/cheaper) hosting service Deployment? #37
Created service: http://hits.dwyl.io / http://hits.dwyl.com (MVP) add hits as a dwyl service available to everyone at hits.dwyl.io ? #22 to avoid the (slow) Heroku startup time.
Remove use of shields.io "proxy badge" relying on shields.io is costing us ... we need to re-consider this... #30 which was super slow! instead use our own SVG template. ✅
fixes: Update dependencies #41 (update dependencies), Browser Language? #43 (record browser language), Simplify /lib/hits.js to do only *one* thing #44 (simplify code!), Format hit data to user friendly format #45 (format data in a user-friendly way in browser), Better Error Logging/Reporting #47 (error logging on server when something goes wrong!).
Using the "curl" response time command https://stackoverflow.com/a/22625150/1148249
we see that response is consistently around 300ms on my crappy 3G connection in PT!
This will form part of the next dwyl "learn" tutorial.
But right now I just want to ship the progress "so far".