Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change popups: resize horizontally and center vertically #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwcoates
Copy link
Owner

@dwcoates dwcoates commented Nov 20, 2019

This change makes board image centered vertically in popup. It also resizes the popup window horizontally to fix to image.

I could not get the image to center horizontally.

You might not notice a difference without a emacs -Q

@dwcoates
Copy link
Owner Author

dwcoates commented Nov 20, 2019

It seems to create window too early, so it hiccups on the first call. I should fix that

@dwcoates
Copy link
Owner Author

A work in progress. Later, I'll try to make it popup below/right intelligently.

@rolandwalker
Copy link
Collaborator

The variable win in (let ( … (win (get-buffer-window buf)) … was perhaps badly named. It's expected to routinely be nil — when the window doesn't exist yet. That way setting window properties only such as (set-window-dedicated-p win t) happens only on the first display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants