Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-fuzz-build: cannot find package "go-fuzz-dep" #320 #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hidu
Copy link

@hidu hidu commented May 8, 2021

No description provided.

@disconnect3d
Copy link

@dvyukov @josharian can this be merged? it makes go-fuzz/go-fuzz-build compilation succeed on latest Go versions or/and in IDEs like Goland.

@josharian
Copy link
Collaborator

@thepudds what do you think?

@thepudds
Copy link
Collaborator

Hi @hidu, thanks for sending this PR.

I'm not sure if it is the right fix though? I suspect it might workaround the immediate error you were seeing, but I wonder if this fix masks that the wrong GOROOT is still being used. I suspect with this fix, it is not instrumenting the standard library properly, but to be honest, I haven't looked at the suggested change closely enough, so that worry might be off base.

Stepping back, though, I wonder if there is a simpler solution that might work for you. See my comment here on the related issue.

@thepudds
Copy link
Collaborator

Hi @disconnect3d, when you say this PR is needed to work with "latest Go versions or/and in IDEs like Goland", are you referring to whether or not go-fuzz is a module itself?

If so, one approach is to work in GOPATH mode if hacking on go-fuzz itself. See some related comments in #332.

If you are not referring to issues arising from whether or not go-fuzz is a module itself, can you expand a bit more on what issues you are seeing? Does it seem to be the same problem described by @hidu in #320?

FWIW, go-fuzz works reasonably well for me with latest Go versions. I don't use Goland, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants