Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non drvfs on wsl environment #136

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

y-hashida
Copy link

@y-hashida y-hashida commented Jan 21, 2023

Hi Preact team!

I have been using vagrant-sshfs on a regular basis!

This time, I want to use this plugin in a wsl environment.

To do so, I need to set the wsl_allow_non_drvfs option to true, so I created this PR based on the official vagrant rsycn shared folder plugin example.

Official Example:

https://github.com/hashicorp/vagrant/blob/5b501a3fb05ed0ab16cf10991b3df9d231edb5cf/plugins/synced_folders/rsync/synced_folder.rb#L52-L56

Thank you.

@y-hashida
Copy link
Author

@dcermak
Excuse me, could you please take a look at this?

@dcermak
Copy link
Contributor

dcermak commented Jul 16, 2023 via email

@y-hashida
Copy link
Author

@dcermak
Sorry...
You are right, I made a mistake in the destination of the mentions.

@@ -126,6 +126,12 @@ def find_executable(name)
ENV['PATH'] = oldpath
return exepath
end

# Enable rsync synced folders within WSL when in use
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Enable rsync synced folders within WSL when in use
# Enable sshfs synced folders within WSL when in use

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still needs to happen

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
I have corrected that comment!

@dustymabe
Copy link
Owner

Is there more context for why this is needed? I don't really understand WSL too much so any context to fill in the gaps would be appreciated.

@y-hashida
Copy link
Author

@dustymabe
Thank you for your reply

In fact, systemd is now supported in WSL2.
With it, libvirt is now available.
I use a plugin called vagrant-libvit to create a vagrant environment on WSL2.

I have tried various vagrant folder synchronization methods and found vagrant-sshfs to be easy to use.
(The mount_options built into vagrant-libvirt did not work correctly, whereas vagrant-sshfs did.)

So I prepared this PR so that vagrant-sshfs can be used with WSL2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants