-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non drvfs on wsl environment #136
base: main
Are you sure you want to change the base?
Conversation
@dcermak |
y-hashida ***@***.***> writes:
@dcermak
Excuse me, could you please take a look at this?
The change looks good to me, but I have neither maintainer rights over
this repo, nor a machine to test this.
Did you maybe want to ping @dustymabe?
|
@dcermak |
lib/vagrant-sshfs/synced_folder.rb
Outdated
@@ -126,6 +126,12 @@ def find_executable(name) | |||
ENV['PATH'] = oldpath | |||
return exepath | |||
end | |||
|
|||
# Enable rsync synced folders within WSL when in use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Enable rsync synced folders within WSL when in use | |
# Enable sshfs synced folders within WSL when in use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this still needs to happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
I have corrected that comment!
Is there more context for why this is needed? I don't really understand WSL too much so any context to fill in the gaps would be appreciated. |
@dustymabe In fact, systemd is now supported in WSL2. I have tried various vagrant folder synchronization methods and found vagrant-sshfs to be easy to use. So I prepared this PR so that vagrant-sshfs can be used with WSL2. |
Hi Preact team!
I have been using vagrant-sshfs on a regular basis!
This time, I want to use this plugin in a wsl environment.
To do so, I need to set the
wsl_allow_non_drvfs
option totrue
, so I created this PR based on the official vagrant rsycn shared folder plugin example.Official Example:
https://github.com/hashicorp/vagrant/blob/5b501a3fb05ed0ab16cf10991b3df9d231edb5cf/plugins/synced_folders/rsync/synced_folder.rb#L52-L56
Thank you.