Implement dynamic height and change vertical padding

[bynect]

Implement dynamic height for notification, namely a way to define a minimum height.

I also changed the behavior of vertical padding to work even when there is no icon.

---

Summary:

• implement dynamic height (min/max)
• generalize implementation of vertical alignment to work without icon and with hide_text
• add functional-test for the changes
• add a test suite for min height
• refactored functional-tests and added them to the makefile
• added height to the docs and fixed some indentation on them

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 66.08%. Comparing base (a6e1d4e) to head (2b407f2).
Report is 9 commits behind head on master.

Files	Patch %	Lines
src/draw.c	42.59%	31 Missing ⚠️
src/settings.c	50.00%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   65.95%   66.08%   +0.13%     
==========================================
  Files          50       50              
  Lines        8209     8247      +38     
  Branches      962      958       -4     
==========================================
+ Hits         5414     5450      +36     
- Misses       2795     2797       +2     

Flag	Coverage Δ
unittests	66.08% <66.66%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bynect]

Everything seems to work. Maybe I will add some functional tests

[bynect]

I noticed that there are some differences from the old behavior so it's not ready yet

[bynect]

Everything is working fine now. I also added test and functional tests.

For a quick check on what this implements use ./test.sh vertical_align

I also noticed some indentation error in the docs and fixed (sorry for not making another pr :d)

[bynect]

I think it's best to merge this before #1337

[bynect]

For a quick check on what this implements use ./test.sh vertical_align

@fwsmit could you test this

[fwsmit]

Sorry, I cannot test at the moment. Maybe someone else can do it?

[bynect]

For a quick check on what this implements use ./test.sh vertical_align

@fwsmit could you test this

@zappolowski could you see this if you have the time

[zappolowski]

Code seems good, but the notifications look different than current master with too much padding on the top and too little at the bottom.

Current master:

This branch:

[zappolowski]

As this is the old default value, I assume that a lot of people will have it in their configuration as well and thus will end up with a weird looking notification. This needs to be communicated very explicitly.

[bynect]

before the height was dynamic by default, but now we can set a minimum. what's the best way to communicate this? maybe a log info in the check settings?

[zappolowski]

I'm not really sure about the best approach here. Maybe an entry in the CHANGELOG marking it as breaking change suffices?

[bynect]

Code seems good, but the notifications look different than current master with too much padding on the top and too little at the bottom.

Current master:

This branch:

I'm not sure this is the intended behavior (except if vertical alignment is bottom I guess) so I will check again. did you test with the default dunstrc?

[zappolowski]

did you test with the default dunstrc?

I've tested it with the built-in default config (./dunst -conf /dev/null) but it looks the same as using the repository's dunstrc (I didn't check whether the built-in defaults and the one from dunstrc differ).

[bynect]

Now it should work as intended.

The only corner case that I am not sure how to handle is when the max height is too small to fit everything

initially it was

then I made it overlap but not go outside the border

but this is just an hack. the real problem is that there is not enough room in this case. I would leave it as it this...

[bynect]

Ok I should have fixed the problem above

edit: just for reference this is the old behavior pre-pr

[bynect]

note for the future: maybe we could save the output of functional tests and compare it automatically in the ci to see if we break the drawing (which is not very covered)

[fwsmit]

How would you compare the output of the functional tests? Pixel for pixel comparison of the images might not work so well, because the font rendering might change slightly with different versions of pango or a font

[bynect]

How would you compare the output of the functional tests? Pixel for pixel comparison of the images might not work so well, because the font rendering might change slightly with different versions of pango or a font

I didn't think about that. Maybe with specific pango and cairo versions

[bynect]

since this seems to work well I'll merge