Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ape store spellbook #6850

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

whalehunting
Copy link
Contributor

@whalehunting whalehunting commented Sep 28, 2024

This PR adds new spellbook for the ApeStore token deployer on Base + Ethereum networks.
It's a continuation of PR #6287 , which was closed due to inactivity (went on vacation)

Contribution type

  • New spell(s)

For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): ape_store.trades
  • Description: Deployments and trades for tokens deployed by ape.store
  • Who are the new spell(s) for? General community
  • How will the new spell(s) be used downstream? Dashboard
  • Implementation details: [Information on how the spell(s) are implemented]
  • Test instructions: Seed tests
  • Related issue(s): None

@dune-eng
Copy link

Workflow run id 11083687441 approved.

@dune-eng
Copy link

Workflow run id 11083743491 approved.

@dune-eng
Copy link

Workflow run id 11083743624 approved.

@dune-eng
Copy link

Workflow run id 11083755901 approved.

@dune-eng
Copy link

Workflow run id 11083756003 approved.

@dune-eng
Copy link

Workflow run id 11083795030 approved.

@dune-eng
Copy link

Workflow run id 11083795028 approved.

@dune-eng
Copy link

Workflow run id 11083807661 approved.

@dune-eng
Copy link

Workflow run id 11083807898 approved.

@dune-eng
Copy link

Workflow run id 11084497284 approved.

@dune-eng
Copy link

Workflow run id 11084497364 approved.

@dune-eng
Copy link

Workflow run id 11084551728 approved.

@dune-eng
Copy link

Workflow run id 11084551870 approved.

@dune-eng
Copy link

Workflow run id 11084658032 approved.

@dune-eng
Copy link

Workflow run id 11084658090 approved.

@dune-eng
Copy link

Workflow run id 11084692340 approved.

@dune-eng
Copy link

Workflow run id 11084692446 approved.

@jeff-dude jeff-dude added the WIP work in progress label Sep 30, 2024
on (
trades.blockchain = deployments.blockchain
and trades.block_month >= deployments.block_month
and (token_bought_address = token or token_sold_address = token)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this or condition really messes with the engines query planning and doesn't run efficiently. i actually ran into the same problem this week, but finally found logic that works more efficiently. you can see here:
https://github.com/duneanalytics/spellbook/pull/6847/files#diff-5dceb884deab38e05245be5fa15b51577bf1a3a220ec6b7c07d27f3e4ce2e52cR52

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same idea below on ethereum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants