-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ape store spellbook #6850
base: main
Are you sure you want to change the base?
feat: add ape store spellbook #6850
Conversation
This reverts commit 71f7925.
Workflow run id 11083687441 approved. |
Workflow run id 11083743491 approved. |
Workflow run id 11083743624 approved. |
Workflow run id 11083755901 approved. |
Workflow run id 11083756003 approved. |
Workflow run id 11083795030 approved. |
Workflow run id 11083795028 approved. |
Workflow run id 11083807661 approved. |
Workflow run id 11083807898 approved. |
Workflow run id 11084497284 approved. |
Workflow run id 11084497364 approved. |
Workflow run id 11084551728 approved. |
Workflow run id 11084551870 approved. |
Workflow run id 11084658032 approved. |
Workflow run id 11084658090 approved. |
Workflow run id 11084692340 approved. |
Workflow run id 11084692446 approved. |
on ( | ||
trades.blockchain = deployments.blockchain | ||
and trades.block_month >= deployments.block_month | ||
and (token_bought_address = token or token_sold_address = token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this or
condition really messes with the engines query planning and doesn't run efficiently. i actually ran into the same problem this week, but finally found logic that works more efficiently. you can see here:
https://github.com/duneanalytics/spellbook/pull/6847/files#diff-5dceb884deab38e05245be5fa15b51577bf1a3a220ec6b7c07d27f3e4ce2e52cR52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same idea below on ethereum
This PR adds new spellbook for the ApeStore token deployer on Base + Ethereum networks.
It's a continuation of PR #6287 , which was closed due to inactivity (went on vacation)
Contribution type
For new spell(s)
If you are building new spell(s), please provide the following information: