-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gas.fees
: enable celo for gas fees
#6846
Conversation
@@ -92,7 +83,7 @@ WITH base_model as ( | |||
,txns.gas_used as gas_used | |||
,{{tx_fee_raw(blockchain) }} as tx_fee_raw | |||
,{{tx_fee_breakdown_raw(blockchain)}} as tx_fee_breakdown_raw | |||
,{{fee_currency(blockchain)}} as tx_fee_currency | |||
,{{var('ETH_ERC20_ADDRESS')}} as tx_fee_currency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
during the fix, looks like blockchain team has cleaned up the raw table to match other chains and the fee_currency
field no longer exists
select fee_currency, *
from celo.transactions
limit 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we can simply remove this here. our non-raw values will break without the decimal assignment, which requires the correct address to join to metadata. i have raised to the team internally again.
currently the test is failing for
need to investigate further. celo docs: |
closing in favor of #6930 |
No description provided.