Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming polygon zkevm in rollup economics #6839

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Jam516
Copy link
Contributor

@Jam516 Jam516 commented Sep 26, 2024

Polygon zkevm has different names in the revenue and cost tables of this spell.

Creates a problem when they are merged by name in user's queries.

Im updating the name in the cost tables so they match the revenue tables.

@dune-eng
Copy link

Workflow run id 11050850586 approved.

@dune-eng
Copy link

Workflow run id 11050850906 approved.

@jeff-dude jeff-dude added the WIP work in progress label Sep 26, 2024
@jeff-dude
Copy link
Member

marking at WIP, as CI is failing on downstream dependencies from name changes

@dune-eng
Copy link

Workflow run id 11070809013 approved.

@dune-eng
Copy link

Workflow run id 11070808713 approved.

@dune-eng
Copy link

Workflow run id 11070844176 approved.

@dune-eng
Copy link

Workflow run id 11070844498 approved.

@Jam516
Copy link
Contributor Author

Jam516 commented Sep 27, 2024

It looks like it works if I don't change the file names. Which is fine by me. I only needed to change the label in the query.

Ready for review @jeff-dude 🙏

@jeff-dude
Copy link
Member

It looks like it works if I don't change the file names. Which is fine by me. I only needed to change the label in the query.

Ready for review @jeff-dude 🙏

is this the spell you're referring to with polygon zkevm naming standard that you are looking to mimic here?

@jeff-dude jeff-dude self-assigned this Sep 27, 2024
@jeff-dude jeff-dude added question Further information is requested in review Assignee is currently reviewing the PR and removed WIP work in progress labels Sep 27, 2024
@Jam516
Copy link
Contributor Author

Jam516 commented Oct 2, 2024

It looks like it works if I don't change the file names. Which is fine by me. I only needed to change the label in the query.
Ready for review @jeff-dude 🙏

is this the spell you're referring to with polygon zkevm naming standard that you are looking to mimic here?

Yep, that's the one

@jeff-dude jeff-dude added ready-for-merging and removed question Further information is requested in review Assignee is currently reviewing the PR labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants