-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stablecoin balances evms #6826
Stablecoin balances evms #6826
Conversation
Workflow run id 11021984662 approved. |
Workflow run id 11021984661 approved. |
Workflow run id 11022225657 approved. |
Workflow run id 11022225565 approved. |
Workflow run id 11022303136 approved. |
Workflow run id 11022303425 approved. |
Workflow run id 11025108461 approved. |
Workflow run id 11025108358 approved. |
Workflow run id 11025108493 approved. |
Workflow run id 11025419582 approved. |
Workflow run id 11025419438 approved. |
Workflow run id 11025419584 approved. |
Workflow run id 11036468370 approved. |
Workflow run id 11036468425 approved. |
Workflow run id 11036468080 approved. |
@jeff-dude Specifically on optimism - I just want to make sure it accounts for legacy transfers |
Otherwise these should be good to go. Note for myself: To add more chain in the future we have to create the base daily balances table for the network first |
raw balances is done outside of spellbook due to compute requirements (v heavy). they are based on transfers spells though, which can be found here:
you can help us validate the optimism transfers there 🙏 |
thanks for this!
|
i think best you can do is look to modify the transfers pipeline for optimism, then balances will pick it up. with this being only legacy, i would have to check with the team on how we'd handle the history for balances, may require a new backfill |
Workflow run id 11097032228 approved. |
Workflow run id 11097032400 approved. |
Workflow run id 11097032385 approved. |
@jeff-dude I removed OP for now. I'll look to handle that it in a separate PR |
Workflow run id 11107294711 approved. |
Workflow run id 11107294478 approved. |
Workflow run id 11107294721 approved. |
Workflow run id 11114862885 approved. |
Workflow run id 11114863081 approved. |
Workflow run id 11114863097 approved. |
@jeff-dude |
okay, revisiting OP after works for me. do you think this PR is in merge-ready state? |
Yea the changes since then are just to the tokens_erc20_stablecoin tables. I ran through similar checks on the balance tables and picked up some issues with them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, let's give this a try.
with this macro gaining more traction (seeing it used in multiple spots), i will catch up with @0xRobin next week on a full plan for these spells
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
This query is for anyone interested in network views of stablecoin balances
**Implementation details:**The stablecoins are defined in the tokens_{network}.erc20_stablecoins tables
Test instructions: unique address/balance/day
Related issue(s): [Link to related issues, if any]
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!