Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core superfluid protocol events to daily spellbook #6669

Closed
wants to merge 7 commits into from

Conversation

leopk-code
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


For new spell(s)

If you are building new spell(s), please provide the following information:

  • Spell name(s): dbt_subprojects/daily_spellbook/models/superfluid/*
  • Description: Seven low-level events that together reflect most of the capabilities of superfluid protocol.
  • Who are the new spell(s) for? For Superfluid and community maintained dashboards
  • How will the new spell(s) be used downstream? Directly in dashboards. Currently no downstream spellbook tables planned
  • Implementation details: Incremental tables based on the logs table for each network
  • Test instructions: na
  • Related issue(s): [Link to related issues, if any]

Additional information

Please provide any additional information that might help us review your pull request:

  • [Any additional information]

Thank you for your contribution!

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709560764 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709561144 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709907529 approved.

@dune-eng
Copy link

dune-eng commented Sep 4, 2024

Workflow run id 10709907625 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10721700614 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10721700728 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10723835250 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10723836070 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10725598156 approved.

@dune-eng
Copy link

dune-eng commented Sep 5, 2024

Workflow run id 10725598492 approved.

Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @leopk-code!
We may add superfluid_ethereum roll-up spells to aggregate chain-level spells, then add post_hook in roll-up spells' config block.

{{ config(
schema = 'superfluid_arbitrum',
alias = 'flow_distribution_updated_events',
materialized = 'incremental',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leopk-code,
for incremental spells,
we need to define the unique_key in config blocks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config:
tags: ['arbitrum', 'DeFi', 'superfluid']
description: >
A table containing all flow updated events on Arbitrum.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we need to test apply

    tests:
      - dbt_utils.unique_combination_of_columns:
          combination_of_columns:

test to unique_key in model schema.

@Hosuke Hosuke self-assigned this Sep 14, 2024
@Hosuke Hosuke added the in review Assignee is currently reviewing the PR label Sep 16, 2024
@cincauhangus
Copy link

Hi there, just FYI @leopk-code has left superfluid and I am taking over his role.

@leopk-code would it be better if I forked your repo to add the changes (and you'll need to merge it in later) or shall I start a new PR from scratch?

@leopk-code
Copy link
Contributor Author

@cincauhangus might be easier to start a new pull request based on my fork!

@0xRobin 0xRobin closed this Oct 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in review Assignee is currently reviewing the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants