-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core superfluid protocol events to daily spellbook #6669
Conversation
Workflow run id 10709560764 approved. |
Workflow run id 10709561144 approved. |
Workflow run id 10709907529 approved. |
Workflow run id 10709907625 approved. |
Workflow run id 10721700614 approved. |
Workflow run id 10721700728 approved. |
Workflow run id 10723835250 approved. |
Workflow run id 10723836070 approved. |
Workflow run id 10725598156 approved. |
Workflow run id 10725598492 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @leopk-code!
We may add superfluid_ethereum
roll-up spells to aggregate chain-level spells, then add post_hook
in roll-up spells' config block.
{{ config( | ||
schema = 'superfluid_arbitrum', | ||
alias = 'flow_distribution_updated_events', | ||
materialized = 'incremental', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @leopk-code,
for incremental
spells,
we need to define the unique_key
in config blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config: | ||
tags: ['arbitrum', 'DeFi', 'superfluid'] | ||
description: > | ||
A table containing all flow updated events on Arbitrum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to test apply
tests:
- dbt_utils.unique_combination_of_columns:
combination_of_columns:
test to unique_key
in model schema.
Hi there, just FYI @leopk-code has left superfluid and I am taking over his role. @leopk-code would it be better if I forked your repo to add the changes (and you'll need to merge it in later) or shall I start a new PR from scratch? |
@cincauhangus might be easier to start a new pull request based on my fork! |
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!