Mass decoding non dynamic

[0xBoxer]

scaleable evm decode function usage

[0xBoxer]

Hey @Hosuke

I just talked to @jeff-dude and he showed me the amount_usd issues that arises within a few trades.

this query in particular: https://dune.com/queries/4093790

The problem here lies within the fact that swap events can be arbitrarily and maliciously emitted by smart contracts, without any connection to reality.

The culprit here is not 1inch, but rather the factory, which somehow also is the Safe token.

The trade it is emitting what looks like a WETH-XXX trade because the factory event was already wrong/didn't make sense.

A way for us to correct this is to simply check if there is corresponding transfer of token_bought or token_sold.

[Hosuke]

dex_automation_beta.trades preview There are 358950146(99.6%) records matched with the existing records in dex.trades, and the rest are trades from newly added uncovered dexes.

I think we can have some initial review feedbacks.

The new implementation has:
uni-v2 ethereum trades: 424567703
uni-v3 ethereum trades: 124873690

[Hosuke]

Now back to incremental error:
https://github.com/duneanalytics/spellbook/actions/runs/11092757311/job/30818194907?pr=6630#step:14:49

This may be an unclear problem.

[jeff-dude]

good progress here!

brainstorming what we still need to do, not in any particular order:

• run tests again of data built in CI here vs. prod dex.trades -- ensure data matches and/or is built as expected, if not exists in prod version (how do we test new DEXs added? can we find a simple, repeatable query to run?)
• naming standards for each spell within the new pipeline, updating file names to match
• macro naming standards for the pipeline, directory structure of where they live, file names of macros, which ones make sense to live in same file
• determine if we stick to just uniswap v2 ethereum for this PR, or open scope to uniswap v2 and v3, both ethereum and arbitrum
• how to name project and version columns when we aren't sure -- do we left join to evms.contracts and look for match? default to unknown if not match?

...maybe more, stopping for now