Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to jsonrpc, to assure our jsonrpc clients behave as expected. #70

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

msf
Copy link
Contributor

@msf msf commented Jul 26, 2024

This validates the following:

  • for a given "stack", we do exactly a specific set of jsonRPC calls, with specific arguments.
  • the response jsonRPC client returns is a simple concatenation of the responses of those calls, in a predefined order.

for the case of arbitrum-nitro, it also validates the correct extraction of the transaction hashes from the eth_getBlockByNumber response. this is trivial, but still good to validate.

@msf msf merged commit e443cc7 into main Jul 30, 2024
1 check passed
@msf msf deleted the add-tests-to-jsonrpc branch July 30, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants