fix null bpt prices on balancer trades #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simeon221
approved these changes
Apr 29, 2023
bh2smith
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed Balancer
dex.tradesis missing some volume due to null BPT prices. Because a lot of users still look into the DEX metrics dashboard (which is on V1) we decided to fix this abstraction but I will push the definitive fix to the spellbook shortly as well. Besides that, I know abstractions have been deprecated so not sure if this is possible but I would appreciate it if you could re-rundex.tradesfor Balancer is the last 7 days so DEX metrics look better.