-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Spotify playlists #101
Open
jackwilsdon
wants to merge
2
commits into
duncan3dc:main
Choose a base branch
from
jackwilsdon:spotify-playlist-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+69
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
<?php | ||
|
||
namespace duncan3dc\Sonos\Tracks; | ||
|
||
use duncan3dc\Sonos\Helper; | ||
|
||
/** | ||
* Representation of a Spotify playlist. | ||
*/ | ||
class SpotifyPlaylist extends Track | ||
{ | ||
const PREFIX = "x-rincon-cpcontainer:"; | ||
const REGION_EU = "2311"; | ||
const REGION_US = "3079"; | ||
|
||
/** | ||
* @var string $region The region code for the Spotify service (the default is EU). | ||
*/ | ||
public static $region = self::REGION_EU; | ||
|
||
|
||
/** | ||
* Create a Spotify playlist object. | ||
* | ||
* @param string $uri The URI of the playlist or the full Spotify ID of the playlist | ||
*/ | ||
public function __construct(string $uri) | ||
{ | ||
# If this is a spotify playlist ID and not a URI then convert it to a URI now | ||
if (substr($uri, 0, strlen(self::PREFIX)) !== self::PREFIX) { | ||
$uri = self::PREFIX . Helper::PLAYLIST_HASH . urlencode($uri); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oddly enough the playlist hash is actually required as part of |
||
} | ||
|
||
parent::__construct($uri); | ||
} | ||
|
||
/** | ||
* Get the metadata xml for this playlist. | ||
* | ||
* @return string | ||
*/ | ||
public function getMetaData(): string | ||
{ | ||
$uri = substr($this->getUri(), strlen(self::PREFIX)); | ||
|
||
return Helper::createMetaDataXml($uri, "-1", [ | ||
"dc:title" => "", | ||
"upnp:class" => "object.container.playlistContainer", | ||
], static::$region); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a "known source" for these hashes @duncan3dc? It seems like a whole host of different ones work for playlists;
The playlist hash I used here is from this issue I found, however the Sonos desktop application seems to use
10060a6c
with my Sonos 🤔.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No they're complete black magic. For Sonos resources (local media library) they're pretty reliable, but as soon as you move to streaming services there's a range in use with no obvious pattern (as you've discovered).
I've made several unsuccessful attempts to figure this out in the past to support Spotify albums. Last time I checked none of the libraries for other languages handled this successfully/reliably, but you might wanna check out their recent versions to see if they've cracked it.
Alternatively I've started a new library (sonos-cloud) which uses the recently published public API for Sonos. This is obviously a lot more reliable than reverse engineering their SOAP calls, but I've not built much with it yet to know if it supports your use case here