Add isReturningUser and isPrivacyProEligible targets and modularize target management #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aitorvs
force-pushed
the
feature/aitor/abn/targets
branch
from
8a8227e
to
65aaec5
Compare
aitorvs
force-pushed
the
feature/aitor/abn/targets
branch
from
65aaec5
to
3df6012
Compare
aitorvs
commented
Nov 15, 2024
| } | ||
|
|
||
| // In the remote config, targets is a list, but it should not be. So we pick the first one (?) | ||
| if (!containsAndMatchCohortTargets(targets.firstOrNull())) { |
There was a problem hiding this comment.
This was certainly wrong before, but we never added more than one target so far so 🤷
nalcalag
reviewed
Nov 15, 2024
Comment on lines
+89
to
+106
| @ContributesMultibinding(AppScope::class) | ||
| class LocaleToggleTargetMatcher @Inject constructor( | ||
| private val appBuildConfig: AppBuildConfig, | ||
| ) : TargetMatcherPlugin { | ||
| override fun matchesTargetProperty(target: Target): Boolean { | ||
| val country = appBuildConfig.deviceLocale.country.lowercase() | ||
| val language = appBuildConfig.deviceLocale.language.lowercase() | ||
|
|
||
| val isCountryMatching = target.localeCountry?.let { | ||
| country == it.lowercase() | ||
| } ?: true | ||
| val isLanguageMatching = target.localeLanguage?.let { | ||
| language == it.lowercase() | ||
| } ?: true | ||
|
|
||
| return isCountryMatching && isLanguageMatching | ||
| } | ||
| } |
There was a problem hiding this comment.
Looking at this logic, I realised we only support one language and one country as a target. If we wanted to test multiple languages, it wouldn’t work, right? Shouldn't it be an array instead of a String?
cc/ @marcosholgado
There was a problem hiding this comment.
it supports multiple languages, targets is an array already, i.e.
"targets": [
{
"variantKey": "mh"
},
{
"variantKey": "mp"
}
]
nalcalag
reviewed
Nov 15, 2024
| ) : TargetMatcherPlugin { | ||
| override fun matchesTargetProperty(target: Target): Boolean { | ||
| return target.isPrivacyProEligible?.let { isPrivacyProEligible -> | ||
| // runBlocking sucks I know :shrug: |
nalcalag
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208710375047087/f
Description
This PR adds couple new targets for FF, ie. isReturningUser and isPrivacyProEligible, both of type
BooleanThe PR also modularizes the way we hande targets, turning them into plugins so that it's easier in the future to add targets without (almost) touching the toggles API
Steps to test this PR
Feature 1