NES: Removes some unnecessary IRAM_ATTR attributes

Functions are called only once per frame AND don't do any intense computation do not belong in IRAM
ducalex · Feb 6, 2024 · e19cacf · e19cacf
1 parent 8a8ea30
commit e19cacf
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/retro-core/components/nofrendo/nes/apu.c b/retro-core/components/nofrendo/nes/apu.c
@@ -76,7 +76,7 @@ static const int dmc_clocks[16] =
 static const int duty_flip[4] = { 2, 4, 8, 12 };
 
 
-IRAM_ATTR void apu_fc_advance(int cycles)
+void apu_fc_advance(int cycles)
 {
    // https://wiki.nesdev.com/w/index.php/APU_Frame_Counter
    const int int_period = 4 * 7457;

diff --git a/retro-core/components/nofrendo/nes/mem.c b/retro-core/components/nofrendo/nes/mem.c
@@ -52,7 +52,7 @@ static const mem_write_handler_t write_handlers[] =
 };
 
 /* Set 2KB memory page */
-IRAM_ATTR void mem_setpage(uint32 page, uint8 *ptr)
+void mem_setpage(uint32 page, uint8 *ptr)
 {
    ASSERT(page < 32);
    ASSERT(ptr);

diff --git a/retro-core/components/nofrendo/nes/ppu.c b/retro-core/components/nofrendo/nes/ppu.c
@@ -636,12 +636,7 @@ bool ppu_enabled(void)
    return (ppu.bg_on || ppu.obj_on);
 }
 
-bool ppu_inframe(void)
-{
-   return (ppu.scanline < 240);
-}
-
-IRAM_ATTR void ppu_endline()
+void ppu_endline(void)
 {
    /* modify vram address at end of scanline */
    if (ppu.scanline < 240 && (ppu.bg_on || ppu.obj_on))

diff --git a/retro-core/components/nofrendo/nes/ppu.h b/retro-core/components/nofrendo/nes/ppu.h
@@ -148,7 +148,6 @@ void ppu_refresh(void);
 void ppu_reset(void);
 void ppu_shutdown(void);
 bool ppu_enabled(void);
-bool ppu_inframe(void);
 void ppu_setopt(ppu_option_t n, uint8_t val);
 uint8_t ppu_getopt(ppu_option_t n);