Refactor sections property #197
Conversation
|
The notebooks are broken, but rewriting those might be best at the end of all refactoring to avoid doing double work. |
| from dtscalibration.datastore_utils import ufunc_per_section_helper | ||
|
|
||
|
|
||
| def set_sections(ds: xr.Dataset, sections: Dict[str, List[slice]]) -> xr.Dataset: |
There was a problem hiding this comment.
Maybe change the name to set_sections_to_ds() to better describe what it does.
There was a problem hiding this comment.
That feels a bit redundant to me. It's a function that takes a dataset and sections, and returns a dataset.
But readthedocs uses the current main branch, such that it will fail if this PR is merged. |
I'll change that to the release version. Which is better anyway, then the docs align with what people install with |
| from dtscalibration.datastore_utils import ufunc_per_section_helper | ||
|
|
||
|
|
||
| def set_sections(ds: xr.Dataset, sections: Dict[str, List[slice]]) -> xr.Dataset: |
calibration_*_endedCloses #196 :
I also added markers to slow tests. By skipping the slow tests, the test suite runs in 1 minute on my machine. This is a lot faster than with all tests, which took >5 minutes.
I skipped the 6 slowest ones. This skips some of the variance tests, but not all of them, so that should be fine when trying to debug other parts of the code base.