Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy, use absolute imports, cleanup old pylint comments #183

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

BSchilperoort
Copy link
Collaborator

This PR adds mypy to the dev depencencies and hatch run lint script, allowing us to start adding type hints.

Additionally, I have moved the code to absolute imports (relative imports can get very messy), and cleaned up some old pylint-disable comments.

@BSchilperoort BSchilperoort linked an issue Jul 29, 2023 that may be closed by this pull request
Copy link
Collaborator

@bdestombe bdestombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good!

@bdestombe
Copy link
Collaborator

Changelog? ;)

@BSchilperoort BSchilperoort merged commit 234276d into main Jul 29, 2023
11 checks passed
@BSchilperoort BSchilperoort deleted the add-mypy branch July 29, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add typing
2 participants