Standardize parameter names #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le ended to double ended
…function. The resample function from dtscalibration was blocking the ability to upgrade to recent versions of xarray and pandas. Resampling using the xarray functions is now proposed, see example notebook 2. See #167
New versions of pandas don't support the squeeze argument
|
Merge #177 first |
BSchilperoort
approved these changes
Jul 25, 2023
| T_dalpha_fw=-self.x * (tmpf ** 2) / self[store_gamma], | ||
| T_alpha_fw=-(tmpf ** 2) / self[store_gamma], | ||
| T_ta_fw=-(tmpf ** 2) / self[store_gamma], | ||
| T_gamma_fw=tmpf / self.gamma, |
There was a problem hiding this comment.
Suggested change
| T_gamma_fw=tmpf / self.gamma, | |
| T_gamma_fw=tmpf / self["gamma"] |
I prefer always accessing xarray variables using the ["var"] syntax, this ensures no conflicts with builtin methods etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #159