Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 403 user options/ handling #1496

Conversation

gamebeaker
Copy link
Collaborator

reference: #1491, #1488, #1361
Added option to block URL.hostname from an 403 error URL.
This can reduce the ammount of errors an user has to skip if the images on the website are now 403 like on patreon.

Changed 403 handling for the user.
Old:
Neues draw io Diagramm-93867 drawio
New:
Only one error page.
image

@gamebeaker gamebeaker merged commit 3314747 into dteviot:ExperimentalTabMode Sep 20, 2024
1 check passed
@dteviot
Copy link
Owner

dteviot commented Sep 20, 2024

@gamebeaker

Did you intend to leave these lines commented out?

/*
if (confirm(chrome.i18n.getMessage("warning403ErrorResponse", new URL(response.url).hostname))) {
// Open site
window.open(new URL(response.url), "_blank").focus();
alert(chrome.i18n.getMessage("wait403ErrorResponse", new URL(response.url).hostname));
} else {
// Do nothing!
}*/

@gamebeaker
Copy link
Collaborator Author

@dteviot no i was debugging and forgot.

@gamebeaker
Copy link
Collaborator Author

@dteviot i pushed a clean up commit here:97a5a40
What should be the workflow if i want to push code?

  1. Should i directly push it in https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode directly without a pull request
    Con:
    I think it is harder to keep track of changes if they get directly merged
    Pro:
    Only 2 Commits in commit history, example:
    image
  2. Create a branch in my fork and create a pull request for this fork in ExperimentalTabMode.
    Con:
    Creates 3 Commits in commit history even for small changes (parser), example:
    image
    Pro:
    I feel like it is easier to keep track of changes especially if they are new functionality/ changes in the code (not parser)

@dteviot
Copy link
Owner

dteviot commented Sep 20, 2024

@gamebeaker

Do whichever you are more comfortable with. I'm good either way.

Also, thank you very much for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants