Library export import function #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes are definitely a more complete / better way of handling it; I went with AddObserver because it was the first method that came to mind to access the object, but considering the frequency "Deletion" will actually be called, reading from storage on call is a far better solution than the constant overhead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kiradien related to #1365 #1365
I changed how the Readinglist gets updated if the book is deleted.
Why?
If you open WebToEpub from a not valid page example in
chrome:
chrome://extensions/firefox:
about:addonsIt wasn't possible to delete a epub.
Additionally i added the deletion of the reading list of the saved books if the Library gets cleared with "Clear Library".
Is that ok or did you have other reason to use .addObserver(library)?
Now the original commit:
Allow the user to export/ import the current Library with reading status as json file.
minor fix: the save as dialog got triggered if "Add to Library" is used on a new url -> now only triggers if the Option "Download Epubs after new Chapter got added automatically" is checked.