New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fanfiction.com.br #1196

Open

LucasFreitaslpf1 wants to merge 1 commit into dteviot:ExperimentalTabMode from LucasFreitaslpf1:ExperimentalTabMode

+928 −468

LucasFreitaslpf1 commented Feb 9, 2024

No description provided.


          added fanfiction.com.br

ed93a83

Owner

dteviot commented Feb 12, 2024

@LucasFreitaslpf1

I'd like to accept this, but as it stands I can't.

NyahFanfictionParser.js is basically fine, except the indentation is 2 spaces, not 4. This results in eslint flagging it with 23 errors. Please fix the indentation or add the following line to the file

/* eslint-disable indent */

(probably) The editor you used to modify popup.html has reformatted the file, resulting in diff flagging almost the entire contents of the file as changed for what should be a single line change.
I can't accept this.
Also, you need to add yourself to the credits section of readme.md and package.json so you get credit for your work.

Fix these, and I'll be delighted to accept this.

For my notes: 19 minutes work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet