Feature #521 main_v5.1 sonarqube_gha #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the workflow_dispatch option can become available via GitHub
…witch to building against the develop version of the dependencies.
27 tasks
bikegeek
reviewed
Apr 22, 2024
bikegeek
reviewed
Apr 22, 2024
There was a problem hiding this comment.
should the METCALCPY, METPLOTPY, and METDATAIO_GIT_NAME be set to main, rather than develop since this is for the main_v5.1 branch? (lines 11, 12, and 13)
…cy versions as main_v2.1 rather than develop. Note that DockerHub already uses the hooks/build file to define the dependencies... but the SonarQube workflow actually uses the versions listed in the Dockerifle. Note that issue #527 will clean up and refine this version depedency logic.
bikegeek
approved these changes
Apr 23, 2024
JohnHalleyGotway
added a commit
that referenced
this pull request
Jul 3, 2024
bikegeek
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Per #527, try switching to met-base image * Per 527, remove yum reference since Python 3.10 is already provided in the dtcenter/met-base image * Per #527, upgrade tomcat to 9.0.89 and java to 17.0.11 * Per #527, add build_metviewer_docker.sh script and update Dockerfile.copy to call it. * Per #529, update call to build script * Per #529, migrate changes to Dockerfile * Per #572, remove geos-3.7.2 unsupported --enable-php configuration option. * Per #527, switch to using dtcenter/met-base-metviewer:v3.2 * Per #527, move configuring build.properties back into the Dockerfiles since it differs for Dockerfile.apptainer. Also modify Dockerfile.apptainer to use the dtcenter/met-base-metviewer image. * Per #526, fix syntax error in build_metviewer_docker.sh * Per #527, get docker build working for apptainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same set of changes as for PR #525, but this is for the main_v5.1 branch. Please review this PR at the same time. These changes are needed in main_v5.1, which is the default branch, to enable the workflow dispatch option to appear via GitHub.
In addition, note the changes in
internal/scripts/docker/hooks/build. This is significant.All of the METviewer builds in DockerHub are surprisingly static:
https://hub.docker.com/r/dtcenter/metviewer/tags
Even though they're labelled
developor6.0.0-beta4, they're actually just building thev6.0.0-beta2release! We should change the logic of this build hook to actually build the intended branch of the code! The dependency logic is a placeholder for now. In the develop branch, we should craft better logic for handling the versions of the METviewer dependencies.