Skip to content

Commit

Permalink
Per #521, define missing DOCKERHUB_REPO and SOURCE_BRANCH envvars
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnHalleyGotway committed Apr 19, 2024
1 parent 7c9f1f8 commit 7dddd4f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/jobs/build_docker_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ DOCKERFILE_PATH=${GITHUB_WORKSPACE}/internal/scripts/docker/Dockerfile.copy

CMD_LOGFILE=${GITHUB_WORKSPACE}/docker_build.log

echo "CURRENT ENVIRONMENT:"
printenv

time_command docker build -t ${DOCKERHUB_TAG} \
--build-arg SOURCE_BRANCH \
--build-arg MET_BASE_REPO \
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/sonarqube.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ on:
default: develop
type: string

env:
DOCKERHUB_REPO: dtcenter/metviewer-dev

jobs:
sonarqube:
name: SonarQube Scan
Expand All @@ -59,6 +62,8 @@ jobs:

- name: Build METviewer in Docker
run: .github/jobs/build_docker_image.sh
env:
SOURCE_BRANCH: ${{ steps.get_branch_name.outputs.branch_name }}

- name: Configure SonarQube
run: .github/jobs/configure_sonarqube.sh
Expand Down

0 comments on commit 7dddd4f

Please sign in to comment.