Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 2675 move to pyproject.toml #2699

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

John-Sharples
Copy link
Contributor

@John-Sharples John-Sharples commented Sep 23, 2024

  • Move to pyproject.toml for build and install
  • removes setup.py and references to it in Dockerfile
  • adds run_metplus as CLI script
  • Note this introduces a duplication of the version number, once in pyproject.toml and again in VERSION. Perhaps not ideal, but I couldn't make setuptools fetch the version from VERSION.

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@John-Sharples John-Sharples added the component: build process Build process issue label Sep 23, 2024
@John-Sharples John-Sharples added this to the METplus-6.0.0 milestone Sep 23, 2024
@John-Sharples John-Sharples marked this pull request as ready for review September 24, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build process Build process issue
Projects
Status: 🔎 In review
Development

Successfully merging this pull request may close these issues.

2 participants