Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2540 Point2Grid config file #2580

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

georgemccabe
Copy link
Collaborator

Note: dtcenter/MET#2880 must be completed before this can be properly tested

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…Grid wrapper -- removed -qc flag argument in favor of setting obs_quality_inc in the config file
@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone May 13, 2024
@georgemccabe georgemccabe linked an issue May 13, 2024 that may be closed by this pull request
22 tasks
@georgemccabe
Copy link
Collaborator Author

After PR #2587 is merged, merge develop and add changes to support/document time_offset_warning for Point2Grid wrapper.

…r other wrappers was merged into develop. Also added support for MET_CONFIG_OVERRIDES for Point2Grid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚧 Stalled
Development

Successfully merging this pull request may close these issues.

Enhancement: Add support for a Point2Grid config wrapper
1 participant